Contributing Guidelines
KernelCI core project is open for contributions. Contributions may consist of adding new builds, tests and device types as well as features and bugfixes for KernelCI core tools. When the PR is created, the KernelCI staging instance takes care of updating the staging.kernelci.org branch. In general the branch is updated every 8h and a limited set of builds and tests are run on it.
There are several guidelines which can facilitate the PR review process:
- Make sure the PR is well described
- Describe the purpose of the changes
- Example use cases are welcome
- Attach staging build/test results when possible.
- If the PR is expected to produce build/test results
check staging viewer and make sure these are mentioned in the PR comment
- Build artifacts including logs are not kept permanently, so it’s generally recommended to put them in a place that’d make them last if you want them to be part of the PR. Good way to do that seem to be:
- Putting important information such as log fragments in the PR comments
- Using services like pastebin to store data important for the PR (e.g. full logs) and pasting the links.
- Build artifacts including logs are not kept permanently, so it’s generally recommended to put them in a place that’d make them last if you want them to be part of the PR. Good way to do that seem to be:
- If the results are not visible on staging and you think they should be, mention it in the comments, too
- If there is specific way to verify PR is working as expected, mention it in the comments
- If the PR is expected to produce build/test results
check staging viewer and make sure these are mentioned in the PR comment
- Make sure that reviewers’ comments and questions are addressed
- When there are comments unanswered for more than 1 month the PR will be closed
- In case there is a need to consult the PR with KernelCI maintainers join the open hours
- Should you need help, you can reach KernelCI maintainers or the community on the KernelCI website
Last modified September 12, 2024